OCPBUGS-50534: Fix error messages in available IP code #9503
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rna-afk: This pull request references Jira Issue OCPBUGS-50534, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
pkg/asset/manifests/azure/cluster.go
Outdated
| @@ -296,5 +296,5 @@ func getNextAvailableIP(ctx context.Context, installConfig *installconfig.Instal | |||
| } | |||
| } | |||
| } | |||
| return "", fmt.Errorf("failed to get available IP in given machine network: %w", err) | |||
| return "", fmt.Errorf("failed to get available IP in given machine network") | |||
There was a problem hiding this comment.
nit: should we include a reason, for example, no available IP (i.e. same for line 286 above)?
I feel like failed to ... alone could mean some unknown internal error, which might not be descriptive enough :D
There was a problem hiding this comment.
+1 for line 299.
Currently, installer seems always running into line 286 when lack of permissions, maybe add reason what Patrick suggested for line 271?
rna-afk
force-pushed
the
fix_available_ip_error_msg
branch
from
babd7d5 to
759b731
Compare
|
The shared vpc job is permafailing until we have openshift/release#61374, so the silver lining is we can see these changes in the ci test results! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@rna-afk: This pull request references Jira Issue OCPBUGS-50534, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pkg/asset/manifests/azure/cluster.go
Outdated
| @@ -296,5 +296,5 @@ func getNextAvailableIP(ctx context.Context, installConfig *installconfig.Instal | |||
| } | |||
| } | |||
| } | |||
| return "", fmt.Errorf("failed to get available IP in given machine network: %w", err) | |||
| return "", fmt.Errorf("failed to get available IP in given machine network: this error may be caused by lack of necessary permissions") | |||
There was a problem hiding this comment.
question: I think here *ipAvail.AvailableIPAddresses is non-empty and we could not find any suitable IP right? How about no available IP or similar?
There was a problem hiding this comment.
There is IP available but at this stage there's no Ip that we can use that's in the machine network so I think it's fine but I am really bad at error messages or commenting so.
There was a problem hiding this comment.
Right, what do you think of using what you just wrote as error message instead (i.e. that is There is IP available but at this stage there's no Ip that we can use that's in the machine network)? Otherwise, LGTM.
There was a problem hiding this comment.
I realized the wordings in my original question was kinda odd. Your latest commit looks great! 👏🏼
Fixing the error messages in the check for available IPs. The error message is always empty since there was no error but there are no IPs available.
rna-afk
force-pushed
the
fix_available_ip_error_msg
branch
from
759b731 to
be7f5b5
Compare
|
/lgtm ^-^ |
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-50534, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fixing the error messages in the check for available IPs. The error message is always empty since there was no error but there are no IPs available.