Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibaba latest Rocket MQ cannot be auto-instrumented. #6741

Closed
sweetxiaodai opened this issue Sep 24, 2022 · 5 comments
Closed

Alibaba latest Rocket MQ cannot be auto-instrumented. #6741

sweetxiaodai opened this issue Sep 24, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@sweetxiaodai
Copy link

sweetxiaodai commented Sep 24, 2022

Describe the bug
A clear and concise description of what the bug is.
Alibaba released their latest RocketMQ v5.0 meanwhile it published its client maven dependencies. However, the otel-
java-auto-instrumentation cannot capture the trace if we use the following client libraries.

Official SDK for public

		<dependency>
			<groupId>org.apache.rocketmq</groupId>
			<artifactId>rocketmq-client-java</artifactId>
			<version>5.0.0</version>
		</dependency>

If you use Alibaba cloud RocketMQ PaaS service, it also provide you with a all-in-one SDK. This also cannot be auto-instrumented by the javaagent.

		<dependency>
			<groupId>com.aliyun.openservices</groupId>
			<artifactId>ons-client</artifactId>
			<!--Replace this with latest Java SDK version-->
			<version>1.8.8.1.Final</version>
		</dependency>

Steps to reproduce
If possible, provide a recipe for reproducing the error.
Use above SDK connect to RocketMQ, and start the jar with javaagent. Observe in jaeger, you cannot find the span and trace.

What did you expect to see?
A clear and concise description of what you expected to see.
Capture produce and consume trace.

What did you see instead?
A clear and concise description of what you saw instead.

What version are you using?
v18.0

Environment
Compiler: OracleJDK1.8
OS: Ubuntu 20.04, MacOS
Runtime "Oracle JRE 8u251"
OS: MacOS

Additional context
Add any other context about the problem here.
contact me if you want to have a short discussion.

@aaron-ai
Copy link
Member

@sweetxiaodai @laurit I'll fix it.

@sweetxiaodai
Copy link
Author

It was done? @aaron-ai awesome

@aaron-ai
Copy link
Member

aaron-ai commented Oct 13, 2022

It was done? @aaron-ai awesome

I am working on it. Related pull request will be created recently, thanks for your attention!

@aaron-ai
Copy link
Member

@sweetxiaodai , thanks for you attention.

This feature has been merged, and you could use it in next release, related issue: #6884 #7019

@mateuszrzeszutek
Copy link
Member

I'll close this issue, since it's implemented now. If you run into any further issues, please reopen or open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants