Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teamcity reporter: output newline after every service message #625

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

dlipovetsky
Copy link
Contributor

Fixes #624

@dlipovetsky dlipovetsky force-pushed the teamcity-reporter-newlines branch from d2251a8 to f40eb32 Compare November 15, 2019 23:17
@blgm
Copy link
Collaborator

blgm commented Nov 18, 2019

Thank you @dlipovetsky. I don't have much context on the teamcity reporter, and it has only been changed once in the past few years - by @manosnoam. So I'll leave this a few days in case @manosnoam has any feedback, since sometimes changes to formats can sometimes break other teams.

@manosnoam
Copy link
Contributor

Hi @dlipovetsky and @blgm,
I see that these are minor changes of adding \n to Teamcity test messages.
Also, it does not affect other reporters, like Junit, so I think it's good to go.

@blgm blgm merged commit 3cfa02d into onsi:master Nov 19, 2019
@blgm
Copy link
Collaborator

blgm commented Nov 19, 2019

Thank you @dlipovetsky and @manosnoam!

@dlipovetsky dlipovetsky deleted the teamcity-reporter-newlines branch November 19, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamCity report does not append a newline to a service message
3 participants