0.6.17 #2270
Merged
0.6.17 #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`error TS2365: Operator '+=' cannot be applied to types 'number' and 'unknown'.`
mbostock
reviewed
Feb 13, 2025
| const response = await fetch(url); | ||
| if (!response.ok) throw new Error("unable to fetch"); | ||
| const source = await response.text(); | ||
| return import(`data:text/javascript;base64,${Buffer.from(source).toString("base64")}`); |
There was a problem hiding this comment.
Node 22 dropped support for --experimental-network-imports in nodejs/node#53822, so I’ve implemented a workaround.
|
Approved! (Pull request authors can’t approve their own pull request.) |
mbostock
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
yarn upgrade)After this is done:
The typescript-eslint issue happens if we
yarn upgrade, then we get this warning when we runyarn test:tsc:due to https://github.com/typescript-eslint/typescript-eslint/blob/81dc579e01c6e95bd347725eab4d9a26a5fc724d/package.json#L123
(A way of dealing with this is to avoid doing
yarn upgradefor the moment.)Fixes #2234.