-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] engine-strict does not work #786
Comments
you can use |
Except nobody does this, people run "npm install" |
So, NPM 7 is now out with no signs of this being fixed. I can't enforce its usage on projects if the feature that does the enforcing doesn't work. |
For anyone coming here it works if you have |
I think NPM should refuse to run any command when the |
npm If your bug is preproducible on If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo Closing: This is an automated message. |
The NPM CLI option "engine-strict" (not to be confused with the engineStrict package.json, which is deprecated) does not work. It does not error out when set to true.
I'm 99% sure it's due to this
npm/npm-install-checks#10
which, as part of deprecating engineStrict completely removed the option to check strictly at all,
NPM CLI still passes the flag to this routine expecting it to respect the flag:
cli/lib/install/validate-args.js
Line 60 in 44ddd0b
So, I'd say
or
or
The text was updated successfully, but these errors were encountered: