Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to mio 0.7 #248

Closed
asafigan opened this issue May 26, 2020 · 10 comments · Fixed by #278
Closed

upgrade to mio 0.7 #248

asafigan opened this issue May 26, 2020 · 10 comments · Fixed by #278

Comments

@asafigan
Copy link

New version of mio is out. Old version relies on a deprecated crate (net2).

@JohnTitor
Copy link
Member

The problem here is that mio-extras also depends on mio 0.6. We should take care of that crate first.

@extrawurst
Copy link
Contributor

that does not seem to happen: dimbleby/mio-extras#7 looks like other major crates like winit rather move away from mio-extras. is that a feasible option?

@JohnTitor
Copy link
Member

I'm in favor of either. Anyway, we should implement our own channel (or re-use crossbeam-channel?). In addition, we could also remove mio itself, though it'll be hard rework.

@extrawurst
Copy link
Contributor

this thing lingering for a while, I think first a simpler and quicker solution and maybe followup with a more involved but nicer one later (but you know the codebase better)

@JohnTitor
Copy link
Member

I think first a simpler and quicker solution and maybe followup with a more involved but nicer one later (but you know the codebase better)

Agreed.

I'm not sure I have some time to look into this in the near future, so any contributions are welcome =)

@JohnTitor JohnTitor added Z-help wanted Z-needs implementation Needs an implementation, will accept PRs and removed Z-needs implementation Needs an implementation, will accept PRs labels Jul 18, 2020
@JohnTitor JohnTitor mentioned this issue Jul 18, 2020
@extrawurst
Copy link
Contributor

Ok I have checked for some reason, the lib already uses both a channel from mio-extras and crossbeam-channel. I could give it a go in removing mio-extras. would you accept a PR for that?

@JohnTitor
Copy link
Member

I could give it a go in removing mio-extras. would you accept a PR for that?

Sure!

@extrawurst
Copy link
Contributor

@JohnTitor ok not gonna happen, I just realize how tightly coupled mio is to their custom channels :(

@JohnTitor
Copy link
Member

Yep, we should have our own items as mentioned above. Thanks for trying anyway!

@Turakar
Copy link

Turakar commented Oct 1, 2020

Hi, I just wanted to let you know that this triggers cargo deny and cargo audit on other repos, like rocket, due to RUSTSEC-2020-0016 which gets resolved by this update according to this thread over at mio. I do understand that this is a bigger change though. Unfortunately, I do not have the time to implement it either ☹️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants