Skip to content
This repository was archived by the owner on Aug 11, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/quic
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 72997d659a84635db791fdf9d8a80d61b326ad8f
Choose a base ref
...
head repository: nodejs/quic
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ea095af59f9ff209b5044f5be634460f5b7b35e5
Choose a head ref
  • 10 commits
  • 22 files changed
  • 1 contributor

Commits on Sep 23, 2019

  1. quic: remove user_data from quic buffer callback 

    Using `std::function` and an opaque pointer are pretty much
antithetical. This commit chooses the more C++-y variant, i.e.
`std::function`.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    dcd4636 View commit details

  2. quic: remove typedef enum 

    Using `typedef enum` is a C-ism.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    52c0cd7 View commit details

  3. quic: cleanup node_quic_buffer.h 

    Prefer inline functions over macros, use explicit nullptr checks,
do not mark functions with implicit inline linkage as inline,
re-use code where possible, etc.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    30eb6e9 View commit details

  4. src: cleanup histogram code 

    Move methods that do not need to be inline into their own file,
replace `std::function` with a template variant for performance,
remove `inline` for functions with implicit inline linkage.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    930fb13 View commit details

  5. quic: remove opaque pointer from Timer callback 

    Use the more C++-y `std::function` approach which renders opaque
pointers unnecessary.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    54e9596 View commit details

  6. quic: cleanup QuicSession code 

    - Do not create new `v8::Function` objects, both for performance
  and because it is unclear whether that leaks memory
  (Node.js issue 28988).
- Do not put functions into the inline header that do not need to
  be there or that do not make sense as inline functions
  (in particular, callbacks that are provided to C libraries can
  not be realized as inline functions by the compiler).
- Remove implicit/redundant `inline` qualifiers and add appropriate
  `const` qualifiers.
- Remove unnecessary `this->` prefixes.
- Return early for JS failures rather than accumulating them.
- Minor stylistic changes.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    cda0d2c View commit details

  7. src: refactor memory tracker implementation 

    Use a template class instead of virtual methods to allow inlining
the subclass methods, as well as other minor cleanups.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    84af079 View commit details

  8. http2: use shared memory tracking implementation 

    The extensive testing done on http2 makes it easier to make sure
the implementation is correct (and doesn’t diverge unnecessarily).

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    6320562 View commit details

  9. quic: remove QuicStreamListener 

    This listener currently had the drawbacks of leaking memory
when an error is encountered and was otherwise equivalent to
the default listener.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    2e29b5c View commit details

  10. quic: more general C++ cleanup 

    Use default initializers, `const` qualifiers, minor style changes
to match more common style in the codebase.

PR-URL: #126
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @addaleax
    addaleax committed Sep 23, 2019
    Copy the full SHA
    ea095af View commit details
Loading