Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: modules.md: fix distance definition #57046

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

alexweej
Copy link
Contributor

It's somewhat esoteric at best to define distance in terms of squared length!

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Feb 14, 2025
@alexweej alexweej changed the title modules.md: fix distance definition doc: modules.md: fix distance definition Feb 14, 2025
It's somewhat esoteric at best to define distance in terms of squared
length!
@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 14, 2025
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 15, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit b6cd6b7 into nodejs:main Feb 16, 2025
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b6cd6b7

@alexweej alexweej deleted the patch-1 branch February 16, 2025 20:37
targos pushed a commit that referenced this pull request Feb 17, 2025
It's somewhat esoteric at best to define distance in terms of squared
length!

PR-URL: #57046
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
It's somewhat esoteric at best to define distance in terms of squared
length!

PR-URL: nodejs#57046
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants