Skip to content

Commit 2f489e0

Browse files
janicduplessisnevilm-lt
authored andcommitted
Use node devtools url (facebook#761)
Summary: **Summary** This uses the new chrome devtools ui, this is the one used by the nodejs inspector. It is more focused on js debugging / profiling instead of general browser devtools. **Test plan** Tested that it works in Flipper and also when opened directly in chrome. ### Before <img width="1396" alt="image" src="https://user-images.githubusercontent.com/2677334/150821665-1e27e6bb-62da-4d1c-8f0b-2b980c2135fe.png"> ### After <img width="1397" alt="image" src="https://user-images.githubusercontent.com/2677334/150821129-ac55243f-3a77-47cf-907c-651568e7215b.png"> Pull Request resolved: facebook#761 Reviewed By: arushikesarwani94 Differential Revision: D34105401 Pulled By: rh389 fbshipit-source-id: f4be7c3e642542e7f90a1c8b9f7535505fffceeb
1 parent d6e16a3 commit 2f489e0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/metro-inspector-proxy/src/InspectorProxy.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ class InspectorProxy {
119119
const debuggerUrl = `${this._serverAddressWithPort}${WS_DEBUGGER_URL}?device=${deviceId}&page=${page.id}`;
120120
const webSocketDebuggerUrl = 'ws://' + debuggerUrl;
121121
const devtoolsFrontendUrl =
122-
'chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=' +
122+
'devtools://devtools/bundled/js_app.html?experiments=true&v8only=true&ws=' +
123123
encodeURIComponent(debuggerUrl);
124124
return {
125125
id: `${deviceId}-${page.id}`,

0 commit comments

Comments
 (0)