feat(core): Add endpoint GET /projects/:projectId/folders (no-changelog) #13519
+753
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
RicardoE105
force-pushed
the
ado-3270-be-add-endpoint-to-list-folders
branch
from
8125da0 to
e4d2f90
Compare
…be-add-endpoint-to-list-folders
…be-add-endpoint-to-list-folders
RicardoE105
commented
Feb 26, 2025
| @@ -213,7 +213,9 @@ export class FolderRepository extends Repository<FolderWithWorkflowCount> { | |||
| direction: 'DESC' | 'ASC', | |||
| ): void { | |||
| if (field === 'name') { | |||
| query.orderBy('LOWER(folder.name)', direction); | |||
| query | |||
| .addSelect('LOWER(folder.name)', 'folder_name_lower') | |||
There was a problem hiding this comment.
Fixes bug that found that throws error if sortBy name without explicitly selecting name
RicardoE105
commented
Feb 27, 2025
|
|
||
| const [data, count] = await this.folderService.getManyAndCount( | ||
| projectId, | ||
| payload as ListQuery.Options, |
There was a problem hiding this comment.
removing this type assertion would require some more refactoring in the folder service and repository as in the workflow service and repository
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #13516
Chain of upstream PRs as of 2025-02-25
PR feat(core): Add endpoint PATCH
/projects/:projectId/folders/:folderId(no-changelog) #13454:master←ado-3168-be-add-endpoint-to-rename-folderPR feat(core): Update PATCH
/projects/:projectId/folders/:folderIdto support tags (no-changelog) #13456:ado-3168-be-add-endpoint-to-rename-folder←ado-3170-be-add-endpoint-to-update-folder-tagsPR feat(core): Add endpoint DELETE
/projects/:projectId/folders/:folderId(no-changelog) #13516:ado-3170-be-add-endpoint-to-update-folder-tags←ado-3167-be-add-endpoint-to-delete-folderado-3167-be-add-endpoint-to-delete-folder←ado-3270-be-add-endpoint-to-list-foldersSummary
This endpoint retrieves a list of available folders where the user can move the contents of a deleted folder.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3270/[be]-add-endpoint-to-list-folders
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)