Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Update PATCH /projects/:projectId/folders/:folderId to support tags (no-changelog) #13456

Merged
merged 47 commits into from
Feb 26, 2025

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Feb 24, 2025

Based on PR #13454

Chain of upstream PRs as of 2025-02-23

Summary

Self explanatory

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3170/[be]-add-endpoint-to-update-folder-tags

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 self-assigned this Feb 24, 2025
@RicardoE105 RicardoE105 changed the title Update PATCH /projects/:projectId/folders/:folderId to support tags feat(core): Update PATCH /projects/:projectId/folders/:folderId to support tags (no-changelog) Feb 24, 2025
@RicardoE105 RicardoE105 requested a review from mutdmour February 24, 2025 02:59
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/services/folder.service.ts 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@RicardoE105 RicardoE105 force-pushed the ado-3168-be-add-endpoint-to-rename-folder branch from fc742f2 to e724446 Compare February 24, 2025 12:24
@RicardoE105 RicardoE105 force-pushed the ado-3170-be-add-endpoint-to-update-folder-tags branch from 07ee307 to 9ce47f3 Compare February 24, 2025 12:25
@RicardoE105 RicardoE105 force-pushed the ado-3168-be-add-endpoint-to-rename-folder branch from e724446 to 23b0f46 Compare February 24, 2025 13:08
@RicardoE105 RicardoE105 force-pushed the ado-3170-be-add-endpoint-to-update-folder-tags branch from 02036a6 to f654bc4 Compare February 24, 2025 13:08
@RicardoE105 RicardoE105 force-pushed the ado-3168-be-add-endpoint-to-rename-folder branch from 23b0f46 to 44deee6 Compare February 24, 2025 14:59
@RicardoE105 RicardoE105 force-pushed the ado-3170-be-add-endpoint-to-update-folder-tags branch from f654bc4 to 6c603b4 Compare February 24, 2025 15:00
@RicardoE105 RicardoE105 requested a review from Cadiac February 26, 2025 12:08
@RicardoE105 RicardoE105 requested a review from Cadiac February 26, 2025 12:17
Copy link
Contributor

@Cadiac Cadiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, lgtm!

Copy link

cypress bot commented Feb 26, 2025

n8n    Run #9487

Run Properties:  status check passed Passed #9487  •  git commit ba86ccdc4a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review ado-3170-be-add-endpoint-to-update-folder-tags
Run status status check passed Passed #9487
Run duration 04m 43s
Commit git commit ba86ccdc4a: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 27852e3 into master Feb 26, 2025
52 of 58 checks passed
@RicardoE105 RicardoE105 deleted the ado-3170-be-add-endpoint-to-update-folder-tags branch February 26, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants