-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Update PATCH /projects/:projectId/folders/:folderId
to support tags (no-changelog)
#13456
Merged
RicardoE105
merged 47 commits into
master
from
ado-3170-be-add-endpoint-to-update-folder-tags
Feb 26, 2025
Merged
feat(core): Update PATCH /projects/:projectId/folders/:folderId
to support tags (no-changelog)
#13456
RicardoE105
merged 47 commits into
master
from
ado-3170-be-add-endpoint-to-update-folder-tags
Feb 26, 2025
+118
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/projects/:projectId/folders/:folderId
to support tags/projects/:projectId/folders/:folderId
to support tags (no-changelog)
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
fc742f2
to
e724446
Compare
07ee307
to
9ce47f3
Compare
e724446
to
23b0f46
Compare
02036a6
to
f654bc4
Compare
23b0f46
to
44deee6
Compare
f654bc4
to
6c603b4
Compare
…be-add-endpoint-to-update-folder-tags
…be-add-endpoint-to-update-folder-tags
This was referenced Feb 26, 2025
Base automatically changed from
ado-3168-be-add-endpoint-to-rename-folder
to
master
February 26, 2025 12:01
Cadiac
reviewed
Feb 26, 2025
packages/@n8n/api-types/src/dto/folders/__tests__/update-folder.request.dto.test.ts
Show resolved
Hide resolved
Cadiac
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, lgtm!
n8n
|
Project |
n8n
|
Branch Review |
ado-3170-be-add-endpoint-to-update-folder-tags
|
Run status |
|
Run duration | 04m 43s |
Commit |
|
Committer | Ricardo Espinoza |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
5
|
|
0
|
|
437
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #13454
Chain of upstream PRs as of 2025-02-23
PR feat(core): Add endpoint POST
/projects/:projectId/folders
(no-changelog) #13446:master
←ado-3179-be-add-endpoint-to-create-folder-v2
PR feat(core): Add endpoint GET
/projects/:projectId/folders/:folderId/tree
(no-changelog) #13448:ado-3179-be-add-endpoint-to-create-folder-v2
←ado-3258-be-add-endpoint-to-the-return-path-to-root-from-children
PR feat(core): Update POST
/workflows
to link folder (no-changelog) #13449:ado-3258-be-add-endpoint-to-the-return-path-to-root-from-children
←ado-3259-be-link-folder-to-workflow-when-workflow-is-saved
PR feat(core): Add endpoint PATCH
/projects/:projectId/folders/:folderId
(no-changelog) #13454:ado-3259-be-link-folder-to-workflow-when-workflow-is-saved
←ado-3168-be-add-endpoint-to-rename-folder
/projects/:projectId/folders/:folderId
to support tags (no-changelog) #13456 (THIS ONE):ado-3168-be-add-endpoint-to-rename-folder
←ado-3170-be-add-endpoint-to-update-folder-tags
Summary
Self explanatory
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3170/[be]-add-endpoint-to-update-folder-tags
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)