Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Implement folder navigation in workflows list #13370

Merged
merged 45 commits into from
Feb 24, 2025

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Feb 19, 2025

Summary

Initial phase of front-end work for folder feature: Folder cards in workflows list
image
In order to achieve this, this PR introduces the following changes:

  • Introducing the new FolderCard component
  • Updating the ResourcesListLayout component to support:
    • Rendering folders along side workflows
    • Introducing separate types for all supported resources (Workflows, Folders, Credentials, Variables)
    • Allowing it to render breadcrumbs in workflows view
  • Fetching folders and workflows from the WorkflowsView

Additional improvements:

  • Workflow sharing badge now shows correct project icon:
    image

How to test

For now, this is only testable locally. Check this Linear comment for more details.

Related Linear tickets, Github issues, and Community forum posts

Closes ADO-3163
Closes ADO-3157
Closes ADO-3155

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Feb 19, 2025
@MiloradFilipovic MiloradFilipovic marked this pull request as draft February 19, 2025 15:22
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 19, 2025
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback. A couple of small questions

mutdmour
mutdmour previously approved these changes Feb 24, 2025
Copy link
Contributor

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Feb 24, 2025

n8n    Run #9443

Run Properties:  status check passed Passed #9443  •  git commit 7f4b6346ce: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ADO-3163-folders-navigation
Run status status check passed Passed #9443
Run duration 04m 37s
Commit git commit 7f4b6346ce: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 0eae14e into master Feb 24, 2025
39 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-3163-folders-navigation branch February 24, 2025 12:52
@github-actions github-actions bot mentioned this pull request Feb 24, 2025
@janober
Copy link
Member

janober commented Feb 25, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants