Add get_post_authors and get_archive_author replacing get_multiple_authors

Fix issue publishpress#593 where secondary authors were dropped from the first post of an author
displayed on its author page. After visiting the author page the post author was reset to
only the first author.

The function get_multiple_authors is deprecated now, and was replaced by two new functions:

get_post_authors, which returns the list of authors of a post (similar behavior when $archive was false).
get_archive_author, which returns the author of the current author page if on an author archive page. If not, returns false. It returns similar result as the $archive argument was true.

Author: andergmartins

publishpress-authors.php

@@ -79,7 +79,7 @@ function wp_notify_postauthor($comment_id, $comment_type = '')
         {
             $comment   = get_comment($comment_id);
             $post      = get_post($comment->comment_post_ID);
-            $coauthors = get_multiple_authors($post->ID);
+            $coauthors = get_post_authors($post->ID);
             foreach ($coauthors as $author) {
                 // The comment was left by the co-author
                 if ($comment->user_id == $author->ID) {

src/core/Classes/Authors_Iterator.php

@@ -63,7 +63,11 @@ public function __construct($postID = 0, $archive = false)
         }
 
         $this->original_authordata = $this->current_author = $authordata;
-        $this->authordata_array    = get_multiple_authors($postID, true, $archive);
+        if ($archive) {
+            $this->authordata_array    = [get_archive_author()];
+        } else {
+            $this->authordata_array    = get_post_authors($postID, $archive);
+        }
 
         $this->count = count($this->authordata_array);
     }

src/core/Classes/Content_Model.php

@@ -120,7 +120,7 @@ public static function filter_author_link($link, $author_id)
     public static function filter_author_display_name($author_meta, $user_id)
     {
         if (empty($author_meta) && empty($user_id)) {
-            $authors = get_multiple_authors();
+            $authors = get_post_authors();
 
             if (!empty($authors)) {
                 // Even for multiple authors, if not specified one, we will always get the first author.
@@ -199,7 +199,7 @@ public static function action_parse_request($query)
 
     public static function filter_ma_get_author_data($data, $field, $post)
     {
-        $authors = get_multiple_authors($post);
+        $authors = get_post_authors($post);
 
         if (empty($authors)) {
             return $data;

src/core/Classes/Post_Editor.php

@@ -106,7 +106,7 @@ public static function action_manage_posts_custom_column($column, $post_id)
         if ('authors' === $column) {
             // We need to ignore the cache for following call when this method were called after saved the post in a
             // quick edit operation, otherwise the authors column will show old values.
-            $authors = get_multiple_authors($post_id, false, false, true);
+            $authors = get_post_authors($post_id, true);
 
             $post_type = get_post_type($post_id);
             $post      = get_post($post_id);
@@ -207,7 +207,7 @@ public static function render_authors_metabox()
             return;
         }
 
-        $authors = get_multiple_authors();
+        $authors = get_post_authors();
 
         echo self::get_rendered_authors_selection($authors, false);  // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
     }

src/core/Classes/Utils.php

@@ -774,7 +774,7 @@ public static function isTheSEOFrameworkInstalled()
 
     public static function isAuthorOfPost($postId, $author)
     {
-        $postAuthors = get_multiple_authors($postId);
+        $postAuthors = get_post_authors($postId);
         if (empty($postAuthors)) {
             return false;
         }

src/core/Plugin.php

@@ -860,7 +860,7 @@ public function add_coauthors($post_id, $coauthors, $append = false)
 
         // Best way to persist order
         if ($append) {
-            $existing_coauthors = wp_list_pluck(get_multiple_authors($post_id), 'user_login');
+            $existing_coauthors = wp_list_pluck(get_post_authors($post_id), 'user_login');
         } else {
             $existing_coauthors = [];
         }
@@ -1157,7 +1157,7 @@ public function filter_the_author($authorDisplayName)
             ! defined('PUBLISHPRESS_AUTHORS_DISABLE_FILTER_THE_AUTHOR')
             || PUBLISHPRESS_AUTHORS_DISABLE_FILTER_THE_AUTHOR !== true
         ) {
-            $authors = get_multiple_authors(get_post());
+            $authors = get_post_authors(get_post());
             if (! empty($authors) && isset($authors[0]) && isset($authors[0]->display_name)) {
                 return $authors[0]->display_name;
             }
@@ -1530,7 +1530,7 @@ public function filter_jetpack_open_graph_tags($og_tags, $image_dimensions)
             }
         } else {
             if (is_singular() && Utils::is_post_type_enabled()) {
-                $authors = get_multiple_authors();
+                $authors = get_post_authors();
                 if (!empty($authors)) {
                     $author = array_shift($authors);
                     if (isset($og_tags['article:author'])) {

src/core/Traits/Author_box.php

@@ -134,7 +134,11 @@ protected function get_author_box_markup(
             $post = $this->postCache[$post_id];
         }
 
-        $authorsList = get_multiple_authors($post_id, true, $archive);
+        if ($archive) {
+            $authorsList = [get_archive_author()];
+        } else {
+            $authorsList = get_post_authors($post_id, true, $archive);
+        }
 
         $this->authorsCount = count($authorsList);
 

src/core/WP_Cli.php

@@ -148,7 +148,7 @@ public function assign_author_by_meta_key($args, $assocArgs)
 
                 // See if the value in the post meta field is the same as any of the existing coauthors
                 $originalAuthor    = get_post_meta($singlePost->ID, $this->args['meta_key'], true);
-                $existingCoauthors = get_multiple_authors($singlePost->ID);
+                $existingCoauthors = get_post_authors($singlePost->ID);
                 $isAlreadyAssociated = false;
                 foreach ($existingCoauthors as $existingCoauthor) {
                     if ($originalAuthor == $existingCoauthor->user_nicename) {

src/functions/amp.php

@@ -11,7 +11,7 @@ function cap_add_amp_actions()
 
     function cap_update_amp_json_metadata($metadata, $post)
     {
-        $authors = get_multiple_authors($post->ID);
+        $authors = get_post_authors($post->ID);
 
         $authors_json = [];
         foreach ($authors as $author) {

src/functions/amp/meta-author.php

@@ -1,4 +1,4 @@
-<?php $coauthors = get_multiple_authors($this->get('post_id')); ?>
+<?php $coauthors = get_post_authors($this->get('post_id')); ?>
 <li class="amp-wp-byline">
     <?php multiple_authors(); ?>
 </li>

src/functions/bylines-functions.php

@@ -17,7 +17,7 @@
      */
     function get_bylines($post = null)
     {
-        return get_multiple_authors($post);
+        return get_post_authors($post);
     }
 }
 

src/functions/coauthors-functions.php

@@ -12,7 +12,7 @@
 if (!function_exists('get_coauthors')) {
     function get_coauthors($post_id = 0)
     {
-        return get_multiple_authors($post_id);
+        return get_post_authors($post_id);
     }
 }
 
@@ -155,7 +155,7 @@ function cap_filter_comment_moderation_email_recipients($recipients, $comment_id
         $post_id = $comment->comment_post_ID;
 
         if (isset($post_id)) {
-            $coauthors        = get_multiple_authors($post_id);
+            $coauthors        = get_post_authors($post_id);
             $extra_recipients = [];
             foreach ($coauthors as $user) {
                 if (!empty($user->user_email)) {