fix suffix '-' for new author slug

ojopaul · ojopaul · commit d960279aff3a · 2022-06-02T13:40:49.000+01:00
diff --git a/src/core/Classes/Admin_Ajax.php b/src/core/Classes/Admin_Ajax.php
@@ -342,14 +342,16 @@ public static function handle_author_slug_generation()
             $author_slug        = !empty($_POST['author_name']) ? sanitize_title($_POST['author_name']) : '';
             $generated_slug     =  $author_slug;
             $generated_slug_n   = '';
-            while (get_term_by('slug', $generated_slug .'-' . $generated_slug_n, 'author')) {
+
+            $new_slug           = $generated_slug;
+            while (get_term_by('slug', $new_slug, 'author')) {
                 if ($generated_slug_n == '') { 
                     $generated_slug_n = 1; 
                 } else {
                     $generated_slug_n++;
                 }
+                $new_slug = $generated_slug .'-' . $generated_slug_n;
             }
-            $new_slug                = $generated_slug .'-' . $generated_slug_n;
             $response['author_slug'] = $new_slug;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -342,14 +342,16 @@ public static function handle_author_slug_generation()`
`342`	`342`	`$author_slug = !empty($_POST['author_name']) ? sanitize_title($_POST['author_name']) : '';`
`343`	`343`	`$generated_slug = $author_slug;`
`344`	`344`	`$generated_slug_n = '';`
`345`		`- while (get_term_by('slug', $generated_slug .'-' . $generated_slug_n, 'author')) {`
	`345`	`+`
	`346`	`+ $new_slug = $generated_slug;`
	`347`	`+ while (get_term_by('slug', $new_slug, 'author')) {`
`346`	`348`	`if ($generated_slug_n == '') {`
`347`	`349`	`$generated_slug_n = 1;`
`348`	`350`	`} else {`
`349`	`351`	`$generated_slug_n++;`
`350`	`352`	`}`
	`353`	`+ $new_slug = $generated_slug .'-' . $generated_slug_n;`
`351`	`354`	`}`
`352`		`- $new_slug = $generated_slug .'-' . $generated_slug_n;`
`353`	`355`	`$response['author_slug'] = $new_slug;`
`354`	`356`	`}`
`355`	`357`