New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full JP address will break HighlightSimilarListingsJob #8

Open

mwsmws22 opened this issue Jan 8, 2022 · 1 comment

Owner

mwsmws22 commented Jan 8, 2022

Most sites only use address like: 東京都練馬区練馬１
But at least one site, aeras, displays a full address in the listing search panel

If a full address was used, the HighlightSimilarListingsJob would break due to the following line

tokyo-listings/tokyo-listings-extension/src/jobs/HighlightSimilarListingsJob.js

Line 42 in 0ff4c95

    
           out.address = JobUtils.buildAddress(out.property, 4, listing.address.includes("丁目"))

Owner Author

mwsmws22 commented Jan 30, 2022

Also diyp uses full address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment