[system] Prevent nested non-vars theme inheritance #45545
Merged
+40
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45544
Root cause
Nested ThemeProvider with non-cssvars theme throws an error when the upper theme is css vars.
The use case is the MUI docs where css vars theme comes from the branding theme and nested theme comes from customization demo.
For full details: #45544 (comment)
Solution
Set
vars: null
to the theme when the theme input does not havevars
, so that it does not inheritvars
from the upper theme.