Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JSON metadata to be submitted to addon submission API #2489

Merged
merged 6 commits into from
Oct 13, 2022
Merged

Allow JSON metadata to be submitted to addon submission API #2489

merged 6 commits into from
Oct 13, 2022

Conversation

eviljeff
Copy link
Member

fixes #2487

@eviljeff eviljeff requested a review from rpl August 26, 2022 11:51
rpl
rpl reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follows an initial set of feedback comments (mainly thoughts and questions in this pass).

@eviljeff eviljeff requested a review from rpl September 7, 2022 17:37
rpl
rpl approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eviljeff lgtm thanks!

@eviljeff
Copy link
Member Author

Note: whichever of #2511 and this pr you merge second will likely need a rebase for conflicts.

@rpl rpl merged commit 8f049d6 into mozilla:master Oct 13, 2022
@eviljeff eviljeff mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpl rpl rpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support passing JSON/form data to the addon submission API
2 participants
@eviljeff @rpl