fix: firefoxPreview option should be set to mv3 only when explicitly requested #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willdurand my apologies, I should have caught this during the review. |
Codecov Report
@@ Coverage Diff @@
## master #2454 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 31 31
Lines 1552 1554 +2
=======================================
+ Hits 1548 1550 +2
Misses 4 4
Continue to review full report at Codecov.
|
willdurand
approved these changes
Jul 8, 2022
|
oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --firefox-preview web-ext option we introduced in v7.1.0 should not default to mv3 if it wasn't explicitly passed as an option (either on the command line or through the web-ext config file).
Unfortunately setting a default value through the yargs
defaultproperty will always setargv.firefoxPreviewto['mv3']even when it is not explicitly passed,demandOptionsset tofalsemakes the cli option not mandatory but it doesn't ignore the default value.This PR adds an additional test case to make sure that
argv.firefoxPreviewisundefinedwhen not explicitly passed as an option, and a small tweak to program.js that make sureargv.firefoxPreviewdefaults to['mv3']if it was set to an empty array (and so when--firefox-previewwas explicitly passed but without any value specified explicitly).