-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Strip UTF-8 BOM before parsing manifest.json/messages.json #1712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are the following ESLint failures (you can apply all suggestions in a bulk commit from the files tab):
Thanks @ExE-Boss for pinging me. I fixed it locally with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rob--W, this looks good to me.
Fixes #1013.
This PR doesn't require a change in package-lock.json, because I purposefully selected a version of strip-bom that was already depended upon via other dependencies. The latest version (4.0.0) does not differ in functionality compared to the chosen version (3.0.0).