Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Strip UTF-8 BOM before parsing manifest.json/messages.json #1712

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Sep 25, 2019

Fixes #1013.

This PR doesn't require a change in package-lock.json, because I purposefully selected a version of strip-bom that was already depended upon via other dependencies. The latest version (4.0.0) does not differ in functionality compared to the chosen version (3.0.0).

@Rob--W Rob--W requested a review from rpl September 25, 2019 17:00
Copy link

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are the following ESLint failures (you can apply all suggestions in a bulk commit from the files tab):

@Rob--W
Copy link
Member Author

Rob--W commented Sep 26, 2019

Thanks @ExE-Boss for pinging me. I fixed it locally with ./node_modules/.bin/eslint --fix tests/unit/test-cmd/test.build.js src/util/manifest.js src/cmd/build.js tests/unit/test-util/test.manifest.js and force-pushed the changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 931cddc on Rob--W:strip-bom into de9fe2c on mozilla:master.

@coveralls
Copy link

coveralls commented Sep 26, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 4022895 on Rob--W:strip-bom into 0d7e491 on mozilla:master.

@rpl
Copy link
Member

rpl commented Sep 26, 2019

@Rob--W would you mind to rebase this PR on top of the current master?
I added an exception in the nsprc file in #1714 (and filed #1713 to remove it as soon as possible) to avoid the CI failure on the "npm audit" step.

Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rob--W, this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web-ext build/run command does not work with manifest.json in utf-8 with BOM encoding
4 participants