Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRX3 files fail #2621

Closed
sean-adams opened this issue Jun 2, 2019 · 0 comments · Fixed by #2638
Closed

CRX3 files fail #2621

sean-adams opened this issue Jun 2, 2019 · 0 comments · Fixed by #2638

Comments

@sean-adams
Copy link

Describe the problem and steps to reproduce it:

Linting a .crx file that is in CRX3 (rather than CRX2) format fails.

Anything else we should know?

This stems from the package dependency on crx-parser. I've submitted a PR that fixes this issue (shyiko/node-crx-parser#2) but considering the library hasn't been published in 4 years I'm not optimistic that it'll get accepted and published.

If there's not a response from the original package maintainer, I'm considering publishing my fork to npm and making a PR to addons-linter to change the dependency, but wanted to get feedback from the addons-linter community before going that route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant