Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy protocol version 2 #23

Open
manvalls opened this issue Apr 11, 2016 · 4 comments
Open

Proxy protocol version 2 #23

manvalls opened this issue Apr 11, 2016 · 4 comments

Comments

@manvalls
Copy link

Hi there, I'm currently using your module to test PRX, I'd like to know if the PROXY protocol version 2 is on the roadmap since it represents around 20% of PRX's code. I don't want to implement it myself as I want PRX's PROXY protocol implementation to be validated by a 3rd party.

@cusspvz
Copy link
Member

cusspvz commented Apr 11, 2016

Hi there,

Didn't knew about the proxy protovol v2, thanks for noticing me. Inspite we already are not using this internally, I've decided to continue its maintenance.

Are there big changes? Are you capable of creating a regexp that covers those changes similar to the existing one?

I'm gonna rest right know but tomorrow I will keep an eye on this and search/study the specs.

EDIT: Nice to hear you're using this module as your test base! :)

@manvalls
Copy link
Author

Well v2 is binary and there is no CRLF so I don't think RegExps are the right tool, there is a 12 bytes signature though.

@cusspvz
Copy link
Member

cusspvz commented May 4, 2017

@manvalls would you be willing to write evaluators and tests for it?

@jlanza
Copy link

jlanza commented Feb 15, 2018

have you already implement v2? from the code it seems no, but just to know if @manvalls or @cusspvz did it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants