[stdlib][Proposal] BinaryHeap struct #3776
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bgreni - thanks for writing this up. I'll add it to the team's weekly design meeting agenda and we'll circle back after we review this. 👍 |
bgreni
force-pushed
the
heap-proposal
branch
2 times, most recently
from
3fee74b to
2c73a1b
Compare
bgreni
force-pushed
the
heap-proposal
branch
3 times, most recently
from
f45fe13 to
2109437
Compare
bgreni
force-pushed
the
heap-proposal
branch
2 times, most recently
from
8f31a85 to
3bc771d
Compare
|
@JoeLoser Was there any discussion about the behaviour of popping from an empty heap? |
bgreni
force-pushed
the
heap-proposal
branch
3 times, most recently
from
c9617b5 to
074545d
Compare
bgreni
force-pushed
the
heap-proposal
branch
from
074545d to
dbe95d9
Compare
bgreni
force-pushed
the
heap-proposal
branch
from
dbe95d9 to
22199a6
Compare
bgreni
force-pushed
the
heap-proposal
branch
5 times, most recently
from
3d29bee to
9310377
Compare
bgreni
force-pushed
the
heap-proposal
branch
3 times, most recently
from
18310e5 to
37601e9
Compare
bgreni
force-pushed
the
heap-proposal
branch
6 times, most recently
from
bbcac13 to
671ae2c
Compare
bgreni
force-pushed
the
heap-proposal
branch
3 times, most recently
from
3c67b7c to
b4490aa
Compare
bgreni
force-pushed
the
heap-proposal
branch
2 times, most recently
from
a985915 to
92c00b9
Compare
Signed-off-by: Brian Grenier <[email protected]>
bgreni
force-pushed
the
heap-proposal
branch
from
92c00b9 to
478bdf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JoeLoser Follow up from this conversation #2999 (comment)
Introduce a proposal for the
BinaryHeapstruct to be considered for inclusion on the stdlib.