Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rector to PHP 8.4, disable mcrypt encryption driver #28

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbolli
Copy link

@mbolli mbolli commented Dec 1, 2024

fixes

  • many TypeErrors à la x must be of type array, null given
  • add #[\Override] attributes where needed
  • disable mcrypt encryption driver (mcrypt_get_iv_size(), mcrypt_encrypt() etc. got removed with PHP 7.2)

todo

  • remove #[\Override] as optional and PHP 8.3 needed
  • verify that ExplicitNullableParamTypeRector did not skip anything
  • maybe do it again from a fresh state with the array rules disabled? there is a huge diff because arrays got reformatted

bugs

  • content pages not accessible in frontend (no error, just empy pjax container)
  • admin: settings mostly don't save
  • admin: site/draft doesn't save and publish changes doesn't work
  • admin: library collection navigation stopped being expandable:
    image
    I was always using albums within albums and this is the condition to display the arrow:
    <!-- ko if: album_type === 'set' && $data.children -->
  • admin: library album view lists subalbums with a number instead of title
    image

@mbolli mbolli marked this pull request as draft December 1, 2024 22:32
@modufolio
Copy link
Owner

@mbolli

Hi Michael, sorry for my late response, I'm recovering from a burnout. Thank you for your help. Please split this PR in 3 or multiple PR's. One for style changes like the formatting of arrays (as you suggested). Please create an PR too that only consist the needed changes to make Koken work on PHP8.4. Changes to the datamapper should always be a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants