Add UI tests for QML #14360
Draft
Add UI tests for QML #14360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
force-pushed
the
feat/ui-test
branch
from
935c149 to
e47563a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a naive attempt to address #12266
Note that QML on Windows doesn't work out of the box and need to manually deploy Qt in the build folder. This workaround was added to the CI, but this should eventually be added in CMake
Note that two commits were also added to address low hanging fruits of #14297 and reduce amount of compute used by our our CI
Note: I was unable to get it running on Mac - I'll see if I can get something but this will likely have to be skipped at first since I don't own a Mac and have limited interest in supporting Apple ecosystem