Skip to content

Commit b60abb8

Browse files
committed
better error tracker grouping
1 parent 4ca8247 commit b60abb8

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

lib/tower_error_tracker/reporter.ex

+2-10
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,3 @@
1-
defmodule TowerErrorTracker.ReportedMessage do
2-
defexception [:level, :message]
3-
4-
def message(%{level: level, message: message}) do
5-
"[#{level}] #{message}"
6-
end
7-
end
8-
91
defmodule TowerErrorTracker.Reporter do
102
@moduledoc false
113

@@ -28,8 +20,8 @@ defmodule TowerErrorTracker.Reporter do
2820
end
2921

3022
def report_event(%Tower.Event{kind: :message, reason: reason, level: level} = event) do
31-
TowerErrorTracker.ReportedMessage.exception(level: level, message: reason)
32-
|> ErrorTracker.report([], context(event))
23+
message = "[#{level}] #{reason}"
24+
ErrorTracker.report({"message #{:erlang.phash2(message)}", message}, [], context(event))
3325

3426
:ok
3527
end

test/tower_error_tracker_test.exs

+5-2
Original file line numberDiff line numberDiff line change
@@ -228,11 +228,14 @@ defmodule TowerErrorTrackerTest do
228228
end)
229229
end)
230230

231+
expected_reason = "[emergency] Panic!"
232+
expected_kind = "message #{:erlang.phash2(expected_reason)}"
233+
231234
assert_eventually(
232235
[
233236
%{
234-
kind: "Elixir.TowerErrorTracker.ReportedMessage",
235-
reason: "[emergency] Panic!",
237+
kind: ^expected_kind,
238+
reason: ^expected_reason,
236239
occurrences: [_]
237240
}
238241
] = TestApp.Repo.all(ErrorTracker.Error) |> TestApp.Repo.preload(:occurrences)

0 commit comments

Comments
 (0)