Incorrect modifier key in placeholder text for committing straight to branch on MacOS

[tyler2grass]

When using the web editor to commit to a remote branch, the text states to use Ctrl+Enter to commit; however, on MacOS this is done by pressing Cmd+Enter.

Version: 1.62.3
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36
Embedder: github.dev

[joyceerhl]

This message is contributed by RemoteHub in web, but I don't believe extensions have a way to look up the keybinding for a given command (which is what we'd need to do to correct this message from RemoteHub itself). The builtin git extension does the right thing:

vscode/extensions/git/src/repository.ts

Lines 2144 to 2149 in 56681ed

	if (branchName) {
	// '{0}' will be replaced by the corresponding key-command later in the process, which is why it needs to stay.
	this._sourceControl.inputBox.placeholder = localize('commitMessageWithHeadLabel', "Message ({0} to commit on '{1}')", '{0}', branchName);
	} else {
	this._sourceControl.inputBox.placeholder = localize('commitMessage', "Message ({0} to commit)");
	}

Some ideas for resolving this:

• ask for a VS Code API to expose the keybinding for a command to extensions
• move this message into core, e.g. into the git-base extension (IIRC builtin extensions do have access to the keybindings service)
• provide a different way to nudge users towards using the simplified commit experience and drop mention of the specific keybinding from the input
• change the keybinding to not use the ctrl key
• other ideas?

[tyler2grass]

Is the full message contributed from RemoteHub, or the message without the keybinding?
Do you happen to know where the RemoteHub source is? I tried searching for it to take a look and only found an archived GitHub repo.

[joyceerhl]

We're blocked on something like #162433 to implement this.

[lszomoru]

Closing this issue as we are currently blocked from implementing this.