SharedImageGalleryTransformer: Take marketplace features #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a SIG is created from a marketplace image, you can provide the source image instead of specifying all of the features, hyper-v gen, and architecture individually.
kamalca
force-pushed
the
kameroncarr/SigTransformer
branch
from
f1a7f1b to
8fea0e7
Compare
squirrelsc
reviewed
Feb 12, 2025
| @@ -643,7 +660,7 @@ def _internal_run(self) -> Dict[str, Any]: | |||
| runbook.gallery_image_osstate, | |||
| runbook.gallery_image_hyperv_generation, | |||
| runbook.gallery_image_architecture, | |||
| runbook.gallery_image_securitytype, | |||
| features, | |||
There was a problem hiding this comment.
The property bag style parameters are not validated by schema, it's hard to find out supported values.
There was a problem hiding this comment.
It is not passed in through the schema, it is collected automatically from the marketplace image. I believe all feature values for a marketplace image are supported for a SIG image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a SIG is created from a marketplace image, you can provide the source image instead of specifying all of the features, hyper-v gen, and architecture individually.