Writing fixes #253
Merged
Writing fixes #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows to easily dump the contents of the whole database objects. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
it turns out that the sub-parameter definitions are not interspersed with the for their default values, but that after all sub-params are outlined, there is a single "COMPLEX-PHYSICAL-DEFAULT-VALUE" tag which defines the default for all of them. This makes a little more sense than my original interpretation of the spec, but I still have questions: - why is the list of subparameters not contained in a "<SUBPARAMS>" tag like almost everything else in ODX? - what is the point of specifying a default value for the complex physical parameter when the constituent parameters can define their own defaults? which values get priority? Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
the SCALE-LABEL subtag can only be omitted if the corresponding attribute is `None`. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
the {MAX,MIN}-NUMBER-OF-ITEMS subtags were missing.
Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Florian Jost <[email protected]>
…g at `.dtc_values` for some reason, this is more stable. Signed-off-by: Andreas Lauser <[email protected]> Signed-off-by: Florian Jost <[email protected]>
andlaus
force-pushed
the
writing_fixes
branch
from
6a8be04 to
e30a6e8
Compare
kayoub5
approved these changes
Jan 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few omissions and minor screwups in the output writing code. With this, the written PDX files hopefully contain a much larger subset of the information (all?) that is contained by database objects.
Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information