Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples 5-8 do not work on Android #278

Closed
metavaults opened this issue Mar 2, 2018 · 1 comment
Closed

Examples 5-8 do not work on Android #278

metavaults opened this issue Mar 2, 2018 · 1 comment

Comments

@metavaults
Copy link

metavaults commented Mar 2, 2018

Is this a bug report or a feature request?

Bug report

Have you read the guidelines regarding bug report?

Yes

Have you read the documentation in its entirety?

Sure

Have you made sure that your issue hasn't already been reported/solved?

Prety sure

Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?

Android

Is the bug reproductible in a production environment (not a debug one)?

Yes

Have you been able to reproduce the bug in the provided example?

Yes!

Environment

Steps to Reproduce

  1. Install the required invornment and launch examples
  2. Examples 5-8 (from (https://github.com/archriss/react-native-snap-carousel/tree/master/example) ) do not work. They are not shown at all (the lists ends with the example 4. on Android).
  3. No logs are provided after executing "react-native log-android".

Expected Behavior

Examples 5-8 should work on Android

Actual Behavior

Examples 5-8 do not work on Android, not shown on the screen

Reproducible Demo

Just check your repo's example folder and try to launch it with my settings.

@metavaults metavaults changed the title Examples 5-10 do not work on Android Examples 5-8 do not work on Android Mar 2, 2018
@bd-arc
Copy link
Contributor

bd-arc commented Mar 2, 2018

@LukasNavickas Yes, that's on purpose.

If you read the source code and this note you'll understand why. To be honest, I went the easy way because I was tired of having to do everything twice thanks to yet another RN bug.

However, in the aforementioned note, I provide 3 workarounds that you can try. The first one should allow you to get it working on Android pretty quickly ;-)

  • Remove the condition !IS_ANDROID
  • Add { elevation: carouselProps.data.length - index } in the relevant animated styles

Note that I'll be working on a complete overhaul of the example as soon as I can free up the time required to do so (see #257 for more info).

@bd-arc bd-arc closed this as completed Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants