Fix: NoMethodError (MAYBE-MARKETING-3W)

[revise-dev]

The error NoMethodError: undefined method '[]' for nil occurs in several select dropdown components when attempting to display the currently selected value. The issue arises when options.find returns nil because no option matches the current value, and then the code attempts to access an array index ([0] or [1]) on this nil result.

The original code assumed that there would always be a matching option in the array, but this isn't guaranteed. For example, if the value prop contains a value that doesn't match any option's second element, find returns nil.

The fix provides a fallback using the Ruby OR operator (||) to default to the first option in the array when no match is found. This maintains the original intent of displaying a selected value while preventing the nil error. For example, if a value of "invalid_period" is passed but the options only contain ["months", "months"] and ["years", "years"], instead of erroring, it will display "months".

The changes ensure graceful degradation while maintaining the component's functionality, making it more robust against invalid or unexpected input values.

Error Details

Summary:

NoMethodError: undefined method '[]' for nil (NoMethodError)

Stacktrace:

action_view/helpers/capture_helper.rb:50
action_view/buffers.rb:75
action_view/helpers/capture_helper.rb:50
action_view/helpers/tag_helper.rb:230
action_view/helpers/tag_helper.rb:123
action_view/base.rb:268
action_view/base.rb:268
action_view/template.rb:284
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/template.rb:583
action_view/template.rb:272
action_view/renderer/partial_renderer.rb:252
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/renderer/partial_renderer.rb:246
action_view/renderer/partial_renderer.rb:237
action_view/renderer/renderer.rb:78
action_view/renderer/renderer.rb:29
action_view/renderer/renderer.rb:24
action_view/helpers/rendering_helper.rb:145
action_view/base.rb:308
action_view/helpers/rendering_helper.rb:141
action_view/helpers/capture_helper.rb:50
action_view/buffers.rb:75
action_view/helpers/capture_helper.rb:50
action_view/helpers/form_helper.rb:776
action_view/base.rb:281
action_view/base.rb:281
action_view/template.rb:284
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/template.rb:583
action_view/template.rb:272
action_view/renderer/partial_renderer.rb:252
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/renderer/partial_renderer.rb:246
action_view/renderer/partial_renderer.rb:237
action_view/renderer/renderer.rb:78
action_view/renderer/renderer.rb:49
action_view/helpers/rendering_helper.rb:152
action_view/base.rb:281
action_view/base.rb:281
action_view/template.rb:284
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/template.rb:583
action_view/template.rb:272
action_view/renderer/partial_renderer.rb:252
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/renderer/partial_renderer.rb:246
action_view/renderer/partial_renderer.rb:237
action_view/renderer/renderer.rb:78
action_view/renderer/renderer.rb:49
action_view/helpers/rendering_helper.rb:152
action_view/helpers/capture_helper.rb:50
action_view/buffers.rb:75
action_view/helpers/capture_helper.rb:50
action_view/helpers/capture_helper.rb:176
action_view/base.rb:281
action_view/base.rb:281
action_view/template.rb:284
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/template.rb:583
action_view/template.rb:272
action_view/renderer/template_renderer.rb:66
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/renderer/template_renderer.rb:60
action_view/renderer/template_renderer.rb:76
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_view/renderer/template_renderer.rb:75
action_view/renderer/template_renderer.rb:59
action_view/renderer/template_renderer.rb:11
action_view/renderer/renderer.rb:58
action_view/renderer/renderer.rb:31
action_view/rendering.rb:136
action_view/base.rb:308
action_view/rendering.rb:135
action_controller/metal/streaming.rb:179
action_view/rendering.rb:122
action_controller/metal/rendering.rb:186
action_controller/metal/renderers.rb:140
abstract_controller/rendering.rb:28
action_controller/metal/rendering.rb:167
action_controller/metal/instrumentation.rb:31
active_support/benchmark.rb:17
action_controller/metal/instrumentation.rb:31
action_controller/metal/instrumentation.rb:100
active_record/railties/controller_runtime.rb:46
action_controller/metal/instrumentation.rb:30
meta_tags/controller_helper.rb:22
action_controller/metal/implicit_render.rb:39
action_controller/metal/basic_implicit_render.rb:9
abstract_controller/base.rb:226
action_controller/metal/rendering.rb:193
abstract_controller/callbacks.rb:261
active_support/callbacks.rb:120
turbo-rails.rb:24
/home/deploy/maybe-marketing-prod/shared/bundle/ruby/3.4.0/gems/turbo-rails-2.0.11/app/controllers/concerns/turbo/request_id_tracking.rb:10
active_support/callbacks.rb:129
action_text/rendering.rb:25
action_text/engine.rb:71
active_support/callbacks.rb:129
active_support/callbacks.rb:129
sentry/rails/controller_transaction.rb:21
sentry/hub.rb:115
sentry/span.rb:237
sentry/hub.rb:113
sentry-ruby.rb:507
sentry/rails/controller_transaction.rb:18
active_support/callbacks.rb:129
active_support/callbacks.rb:140
abstract_controller/callbacks.rb:260
action_controller/metal/rescue.rb:27
action_controller/metal/instrumentation.rb:76
active_support/notifications.rb:210
active_support/notifications/instrumenter.rb:58
sentry/rails/tracing.rb:56
active_support/notifications.rb:210
action_controller/metal/instrumentation.rb:75
action_controller/metal/params_wrapper.rb:259
active_record/railties/controller_runtime.rb:39
abstract_controller/base.rb:163
action_view/rendering.rb:40
action_controller/metal.rb:252
action_controller/metal.rb:335
action_dispatch/routing/route_set.rb:67
action_dispatch/routing/route_set.rb:50
action_dispatch/journey/router.rb:53
action_dispatch/journey/router.rb:133
action_dispatch/journey/router.rb:126
action_dispatch/journey/router.rb:126
action_dispatch/journey/router.rb:34
action_dispatch/routing/route_set.rb:908
logtail-rails/error_event.rb:24
logtail-rack/http_events.rb:213
logtail-rack/user_context.rb:74
logtail-rails/session_context.rb:16
logtail-rack/http_context.rb:23
logtail/current_context.rb:120
logtail/current_context.rb:44
logtail-rack/http_context.rb:22
rack/static.rb:161
rack/tempfile_reaper.rb:20
rack/etag.rb:29
rack/conditional_get.rb:31
rack/head.rb:15
action_dispatch/http/permissions_policy.rb:38
action_dispatch/http/content_security_policy.rb:38
rack/session/abstract/id.rb:274
rack/session/abstract/id.rb:268
action_dispatch/middleware/cookies.rb:706
action_dispatch/middleware/callbacks.rb:31
active_support/callbacks.rb:100
action_dispatch/middleware/callbacks.rb:30
sentry/rails/rescued_exception_interceptor.rb:14
action_dispatch/middleware/debug_exceptions.rb:31
sentry/rack/capture_exceptions.rb:30
sentry/hub.rb:269
sentry-ruby.rb:420
sentry/rack/capture_exceptions.rb:21
sentry/hub.rb:59
sentry-ruby.rb:400
sentry/rack/capture_exceptions.rb:20
action_dispatch/middleware/show_exceptions.rb:32
rails/rack/logger.rb:41
rails/rack/logger.rb:29
action_dispatch/middleware/remote_ip.rb:96
action_dispatch/middleware/request_id.rb:34
rack/method_override.rb:28
rack/runtime.rb:24
active_support/cache/strategy/local_cache_middleware.rb:29
action_dispatch/middleware/executor.rb:16
action_dispatch/middleware/static.rb:27
rack/sendfile.rb:114
action_dispatch/middleware/ssl.rb:92
rails/engine.rb:535
puma/configuration.rb:279
puma/request.rb:99
puma/thread_pool.rb:390
puma/request.rb:98
puma/server.rb:472
puma/server.rb:254
puma/thread_pool.rb:167

Tip

You can make revisions or ask questions of Revise.dev by using /revise in any comment or review!

• /revise Add a comment above the method to explain why we're making this change.
• /revise Why did you choose to make this change specifically?

Important

If something doesn’t look right, click to retry this interaction.

Quick links: View in Sentry • View in Revise