-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR][CIRGen][NFC] Consolidate RUN lines for builtin tests #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trying to improve things, but I don't think this is the direction to go:
- These existing builtins tests are actually nicely categorized for what they cover.
- Most all tests have been designed to contain both CIR and LLVM outputs, I've been asking that for at least 6 months - easier to read and figure out bits all in one place, I don't see a rationale on why this is better.
- If you want a generic place for builtins you could create a
builtin.cpp
file for that and add new ones there, or ones that don't seem to require their own file. Note that there's not a single rule on how to go about these. bultins-overflow.cpp
could probably be renamed tobuiltin-overflow.cpp
to make names more uniform across the board.
Note: if for some reason while unifying things you find out that some don't have LLVM lowering yet, you can workaround by passing a |
db4c9f9
to
6c242ed
Compare
Just as note, Bruno and I talked, and we repurposed this PR. |
There is no change to testing functionality. This refacot let those files have the same Run options that is easier to maintain and extend.
There is no change to testing functionality. This refacot let those files have the same Run options that is easier to maintain and extend.
There is no change to testing functionality. This refacot let those files have the same Run options that is easier to maintain and extend.