Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for cookies with the same name to DefaultCookieJar #6126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suzuki764
Copy link

@suzuki764 suzuki764 commented Feb 25, 2025

Motivation:

The DefaultCookieJar does not handle cases where cookies with the same name are set.

Modifications:

  • Added processing in accordance with RFC 6265:
    • Overwrites existing cookies when a cookie with the same name, domain, and path is set.
    • If the existing cookie has the HttpOnly flag set and the new cookie is created by a non-HTTP API, the new cookie is ignored.

Result:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CookieClient appends cookies with the same name
1 participant