Include ConnectTimeoutException in timeout exceptions for rules
#6107
+120
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
`CircuitBreakerRuleBuilder.onTimeException()` and
`RetryRuleBuilder.onTimeoutException()` only handle Armeria's
`com.linecorp.armeria.common.TimeoutException`. Howerver, they do not
treat Netty`s `ConnectTimeoutException` as a timeout.
Modifitions:
- Treat Netty's `ConnectTimeoutException` and
`ProxyConnectException("timeout")` as a timeout for rules.
Result:
`CircuitBreakerRuleBuilder.onTimeException()` and `RetryRuleBuilder.onTimeoutException()`
now work when a connection or proxy establishment is timed out.
jrhee17
approved these changes
Feb 18, 2025
core/src/main/java/com/linecorp/armeria/internal/common/TimeoutExceptionPredicate.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
CircuitBreakerRuleBuilder.onTimeException()andRetryRuleBuilder.onTimeoutException()only handle Armeria'scom.linecorp.armeria.common.TimeoutException. However, they do not treat NettysConnectTimeoutException` as a timeout.Modifications:
ConnectTimeoutExceptionandProxyConnectException("timeout")as a timeout for rules.Result:
CircuitBreakerRuleBuilder.onTimeException()andRetryRuleBuilder.onTimeoutException()now work when a connection or proxy establishment is timed out.