-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider exposing DnsNameResolverBuilder
or DnsNameResolverBuilder#datagramChannelStrategy
#6122
Comments
Are you considering exposing armeria/core/src/main/java/com/linecorp/armeria/client/AbstractDnsResolverBuilder.java Lines 521 to 533 in d4d72aa
|
Right, similar to how we are already exposing Alternatively, I think we can also expose |
Continuously updating the API might be painful. However, the Netty API hasn’t changed frequently recently and there’s already a delegated builder for DNS resolver. So I’m slightly leaning toward adding setters to How about considering introducing a customizer if a similar issue arises again in the future? |
We could also introduce a new |
Im also looking at this exact issue, was hoping that the |
It seems like the other maintainers prefer that
Let me just expose |
Motivation
We received a report where the nameserver address isn't being updated.
netty/netty#14382
netty/netty#14364
A possible cause could be that the channel is cached per resolver by default, which may not reflect nameserver updates correctly.
Proposal
I propose that we expose the
DnsNameResolverBuilder#datagramChannelStrategy
as well as additional useful options inAbstractDnsResolverBuilder
.Alternatively, I think we could also expose the
DnsNameResolverBuilder
directly so that users can modify specific settings with more freedom.ref: https://discord.com/channels/1087271586832318494/1341789100000415817/1341789105461264384
The text was updated successfully, but these errors were encountered: