Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not skip udp ports in guest agent #3186

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −5
Draft

do not skip udp ports in guest agent #3186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pkg/guestagent/kubernetesservice/kubernetesservice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ func (s *ServiceWatcher) GetPorts() []Entry {
}

for _, portEntry := range service.Spec.Ports {
if portEntry.Protocol != corev1.ProtocolTCP {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a check if grpc vs ssh is being used?

Copy link
Member

@nirs nirs Feb 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the guest agent knows it would be nice to skip only when using the ssh port forwarder. But it is more important to get this working first, optimizing can be done later.

// currently only TCP port can be forwarded
continue
}

var port int32
if service.Spec.Type == corev1.ServiceTypeNodePort {
port = portEntry.NodePort
Expand Down
Loading