feat(libp2p): implement message sizes per topic. #5868
Conversation
… warnings from clippy, check and fmt. Modifies test cases to use TopicMeshConfig::default() in place of explicit default values
|
@AgeManning I opened this PR in regards to #5745. It still needs some work to ensure consistency and correctness, although, I want to get it in front of the appropriate parties to ensure the PR is in the right direction in regards to the objective. |
There was a problem hiding this comment.
Thanks for the PR. I did leave a comment but i wonder if we should in a way assign the size to the topic after the behavior is constructed (eg assigning it to TopicHash or via Behaviour::subscribe or through some means) vs providing it in the config, which i believe the former is meant to be intended, though I could be wrong.
protocols/gossipsub/src/config.rs
Outdated
|
|
||
| /// The topic configuration sets mesh parameters for a given topic. See [`TopicMeshConfig`] | ||
| /// for defaults. | ||
| pub fn set_topic_config(&mut self, topic: TopicHash, config: TopicMeshConfig) -> &mut Self { |
There was a problem hiding this comment.
Is there a reason why we should set the topic in the config itself?
There was a problem hiding this comment.
Set topic will be removed from Config as it was only meant to be on ConfigBuilder. It's just a duplicate I placed there while refactoring
There was a problem hiding this comment.
This looks good imo.
Do we need to clone the config everytime we read it?
Also, I think it would be nice to maintain backwards compatibility. i.e, if users are already using mesh_n() then it works as before, I think it would be nice to add additional config, like mesh_n_topic() which changes just that topic, all others revert to the default or if mesh_n() etc was set.
Nice work.
You're right. I will look into removing the unnecessary cloning and the backwards compatibility makes sense. I will try to get this wrapped up this weekend between tomorrow and Sat. |
…ables and max transmit size.
elijahhampton
changed the title
elijahhampton
changed the title
Description
Fixes: #5745
Notes & open questions
N/A
Change checklist