New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky TestFindPeerQueryMinimal #1036

Merged

guillaumemichel merged 1 commit into master from fix/791

Feb 19, 2025

Contributor

guillaumemichel commented Feb 19, 2025

Fixes #791

to make sure that all peers are found, set Resiliency to bucketSize
if self (guy) is among the closest peers of the key that is looked up, the test may fail
- in this case we don't look for the bucketSize closest peers, but for the bucketSize+1 closest peers, excluding self, hence the last peer may not be correct
fix: if self is among the closest peers, add it to the list of returned peers when checking for the closest peers


          fix: flaky TestFindPeerQueryMinimal

b5d01f8

guillaumemichel requested a review from a team as a code owner

February 19, 2025 16:05

guillaumemichel merged commit c1e046d into master

7 checks passed

guillaumemichel deleted the fix/791 branch

February 19, 2025 16:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet