Narek/async task missing task fix #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike other tests which run in their own isolated database, this test runs on the postgres database, as pg_cron background jobs are only available there. As a result, we have to be more careful cleaning up after the test to make sure that when the same test is run again, it will not run into conflicts with resources it created in the last round
…succeeding When the user submits an async_task that has more than one statement, and the first statement succeeds, then the result of the job currently ends up as 'succeeded' even if the rest of the statements fail
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
rows are filtered on pg_cron_job name = c.jobname, so overwriting the value has no effect and makes the code confusing
Ngalstyan4
force-pushed
the
narek/async-task-missing-task-fix
branch
from
9aeee18 to
bc64c8a
Compare
Make sure update script of lantern.tasks only triggers if the table exists (async_tasks are enabled)
Ngalstyan4
force-pushed
the
narek/async-task-missing-task-fix
branch
from
b4089e8 to
2083602
Compare
var77
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.