Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify params for bedrock retrieve generate #13182

Conversation

warren830
Copy link
Contributor

@warren830 warren830 commented Feb 4, 2025

Summary

Resolves #13201

In addition, add return type for bedrock_retrieve

Screenshots

image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Feb 4, 2025
@crazywoola
Copy link
Member

Please link an existing issue or creating one.

@warren830
Copy link
Contributor Author

Please link an existing issue or creating one.

Thanks for review, I should have set this as a draft yesterday

@crazywoola crazywoola merged commit 03243cb into langgenius:main Feb 5, 2025
8 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tool Bedrock retrieve-and-generate needs to support more params
2 participants