Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log add trace id #11599

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Conversation

luckylhb90
Copy link
Contributor

@luckylhb90 luckylhb90 commented Dec 12, 2024

Summary

feat: log add trace id

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 12, 2024
@crazywoola crazywoola requested a review from laipz8200 December 12, 2024 13:43
@laipz8200
Copy link
Member

Could you associate this PR with an issue and provide a detailed description of your scenario and why you need this feature? This will help us assess its impact. Thank you!

@luckylhb90
Copy link
Contributor Author

Could you associate this PR with an issue and provide a detailed description of your scenario and why you need this feature? This will help us assess its impact. Thank you!

Without pr, this is a very common scenario, because our logs are collected from a Kibana-like system through kafka, and without trace id, it is difficult for us to correlate the context and troubleshoot the problem.

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think this can serve as the current solution. However, please note that once we have similar requirements in the future, the current log format might be affected. Please stay tuned for our updates.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 13, 2024
@crazywoola crazywoola merged commit 38e155d into langgenius:main Dec 15, 2024
5 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants