Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better bedrock message handler close #10976 #11317

Merged
merged 9 commits into from
Dec 4, 2024

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Dec 4, 2024

Summary

add a placeholder to bypass Bedrock models not support two roles next to each other
close #10976

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 4, 2024
@crazywoola
Copy link
Member

@ybalbert001 Please take a look at this.

Signed-off-by: yihong0618 <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 4, 2024
@laipz8200
Copy link
Member

I think it's better to merge two user prompts into one. a 'placeholder' text may change the model's behavior.

btw, its limit is from Claude, not the bedrock.

Signed-off-by: yihong0618 <[email protected]>
@yihong0618
Copy link
Contributor Author

I think it's better to merge two user prompts into one. a 'placeholder' text may change the model's behavior.

btw, its limit is from Claude, not the bedrock.

fixed and turn out most of bedrock model had this problem

@ybalbert001
Copy link
Contributor

@ybalbert001 Please take a look at this.

OK

@ybalbert001
Copy link
Contributor

I test it in my environment. it's ok, I suggest wrap this code in function with better naming.

@yihong0618
Copy link
Contributor Author

I test it in my environment. it's ok, I suggest wrap this code in function with better naming.

I think code leave here with comments is better since it maybe a temp solution and when upstream update we can delete them

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 4, 2024
@laipz8200 laipz8200 merged commit 961e25f into langgenius:main Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bedrock validation error for question clasifier in workflow
4 participants