Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify regex #41

Closed
domdepasquale opened this issue May 15, 2024 · 1 comment
Closed

Simplify regex #41

domdepasquale opened this issue May 15, 2024 · 1 comment

Comments

@domdepasquale
Copy link
Contributor

Since yq 4.44.1 broke the regex here... "[:<>|*?/\\]"

I feel like this regex might be too complicated anyway.

The k8s specification states that names must meet the following https://kubernetes.io/docs/concepts/overview/working-with-objects/names/

Simply, RFC1123. Let's just make a regex that handles those permitted characters instead.

If a user creates a metadata.name with invalid RFC1123, that's a bigger problem beyond the scope of this project.

@domdepasquale
Copy link
Contributor Author

@highb, do you still use this project? If not, I'll take care of this stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant