Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute path when calling crictl version #15642

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Use absolute path when calling crictl version #15642

merged 1 commit into from
Jan 19, 2023

Conversation

afbjorklund
Copy link
Collaborator

Some legacy systems don't have /usr/local/bin in secure_path

So they are not able to find any locally installed tools...

Regression:

@afbjorklund
Use absolute path when calling crictl version
4cf467c 
Some legacy systems don't have /usr/local/bin in secure_path

So they are not able to find any locally installed tools...
@afbjorklund afbjorklund requested a review from spowelljr January 13, 2023 16:45
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2023
@k8s-ci-robot k8s-ci-robot requested a review from medyagh January 13, 2023 16:45
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2023
@afbjorklund
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 14, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15642) |
+----------------+----------+---------------------+
| minikube start | 54.7s    | 56.2s               |
| enable ingress | 28.3s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.7s 29.8s 28.8s 28.3s 26.2s
Times for minikube (PR 15642) ingress: 29.3s 28.8s 28.2s 28.3s 28.8s

Times for minikube start: 56.0s 53.8s 53.9s 53.3s 56.5s
Times for minikube (PR 15642) start: 53.6s 55.7s 58.4s 58.2s 55.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15642) |
+----------------+----------+---------------------+
| minikube start | 26.6s    | 26.7s               |
| enable ingress | 20.7s    | 20.6s               |
+----------------+----------+---------------------+

Times for minikube start: 28.5s 25.9s 25.9s 26.6s 26.0s
Times for minikube (PR 15642) start: 26.3s 26.7s 27.6s 26.2s 26.7s

Times for minikube ingress: 19.0s 21.5s 19.5s 21.0s 22.5s
Times for minikube (PR 15642) ingress: 20.5s 20.5s 19.5s 21.5s 21.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15642) |
+----------------+----------+---------------------+
| minikube start | 25.8s    | 22.9s               |
| enable ingress | 26.3s    | 26.4s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.0s 26.0s 26.0s 26.5s 27.0s
Times for minikube (PR 15642) ingress: 27.0s 27.0s 26.0s 26.0s 26.1s

Times for minikube start: 22.4s 23.7s 22.4s 37.5s 23.0s
Times for minikube (PR 15642) start: 21.9s 23.2s 23.2s 22.4s 23.7s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestFunctional/parallel/DashboardCmd (gopogh) 0.90 (chart)
KVM_Linux_containerd TestRunningBinaryUpgrade (gopogh) 1.26 (chart)
none_Linux TestAddons/parallel/MetricsServer (gopogh) 25.00 (chart)
Docker_Linux_containerd TestMultiNode/serial/DeleteNode (gopogh) 25.62 (chart)
Hyperkit_macOS TestPause/serial/SecondStartNoReconfiguration (gopogh) 27.03 (chart)
Docker_Linux_containerd TestMultiNode/serial/RestartKeepsNodes (gopogh) 27.50 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 39.47 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 52.63 (chart)
Docker_macOS TestMultiNode/serial/RestartKeepsNodes (gopogh) 56.38 (chart)
Hyper-V_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 70.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/flannel/Start (gopogh) 70.00 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 70.00 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 70.00 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 71.03 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 77.24 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 79.37 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 81.31 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 81.31 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 83.18 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 85.05 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/HairPin (gopogh) 91.30 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 94.74 (chart)
KVM_Linux TestMultiNode/serial/ValidateNameConflict (gopogh) 97.14 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 97.99 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 99.17 (chart)
Docker_Linux_containerd TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_Linux_containerd TestPreload (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

medyagh
medyagh approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but would look better with TrimSpace

pkg/minikube/node/start.go
if err != nil {
return err
}
crictl := strings.TrimSuffix(rr.Stdout.String(), "\n")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use "TrimSpace" ? for removing all sort of unexpected spaces ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no whitespace expected, except for the newline from the which command

$ which crictl | cat -vte
/usr/local/bin/crictl$

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit ae7cb58 into kubernetes:master Jan 19, 2023
@afbjorklund afbjorklund mentioned this pull request Feb 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @minikube-pr-bot @k8s-ci-robot @medyagh