Implement target node option for cp command

[daehyeok]

fixes #11146

before

Copy the specified file into minikube, it will be saved at path <target file absolute path> in your minikube.
Example Command : "minikube cp a.txt /home/docker/b.txt"

Usage:
  minikube cp <source file path> <target file absolute path> [flags] [options]

Use "minikube options" for a list of global command-line options (applies to all commands).

after

Copy the specified file into minikube, it will be saved at path <target file absolute path> in your minikube.
Example Command : "minikube cp a.txt /home/docker/b.txt"
                  "minikube cp a.txt minikube-m02:/home/docker/b.txt"

Usage:
  minikube cp <source file path> <target node name>:<target file absolute path> [flags] [options]

Use "minikube options" for a list of global command-line options (applies to all commands).

[k8s-ci-robot]

Hi @daehyeok. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[ilya-zuyev]

':' can be a part of filepath

➜  minikube git:(master) ✗ out/minikube ssh -- sudo mkdir "/tmp/bar:"
➜  minikube git:(master) ✗ out/minikube cp foo /tmp/bar:/foo         
➜  minikube git:(master) ✗ out/minikube ssh -- ls '/tmp/bar:/'      
foo

➜  minikube git:(copy_node) ✗ out/minikube ssh -- sudo mkdir "/tmp/bar:"
➜  minikube git:(copy_node) ✗ out/minikube cp foo /tmp/bar:/foo    

X Exiting due to GUEST_NODE_RETRIEVE: Node /tmp/bar does not exist.

May be it's better to add a new cli key, --target-node or something like this

[daehyeok]

@ilya-zuyev oops. changed to extract node name only when destPath is not a absolute path(not start with '/').
We only allowed absolute path for remote destination, so file with ':' character will be not a problem.
and if we use another flag for node name, we will need another flag for #11296 in future.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daehyeok, ilya-zuyev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ilya-zuyev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ilya-zuyev]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11304) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 51.6s               |
| enable ingress | 36.7s    | 35.9s               |
+----------------+----------+---------------------+

Times for minikube start: 53.5s 46.9s 52.3s 47.8s 47.6s
Times for minikube (PR 11304) start: 55.2s 48.8s 51.5s 48.5s 53.9s

Times for minikube ingress: 34.7s 35.3s 42.3s 36.3s 34.8s
Times for minikube (PR 11304) ingress: 35.3s 35.7s 36.2s 37.4s 34.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11304) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.5s               |
| enable ingress | 34.4s    | 34.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 35.0s 30.0s 34.0s 37.0s 36.0s
Times for minikube (PR 11304) ingress: 32.0s 34.5s 34.0s 38.0s 34.5s

Times for minikube start: 22.2s 21.8s 22.1s 21.4s 20.3s
Times for minikube (PR 11304) start: 21.4s 21.0s 21.8s 21.4s 21.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11304) |
+----------------+----------+---------------------+
| minikube start | 44.6s    | 44.9s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 44.4s 47.8s 43.6s 43.4s 43.9s
Times for minikube (PR 11304) start: 43.4s 43.2s 46.7s 44.4s 46.9s

[k8s-ci-robot]

@daehyeok: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-minikube-build	7c2e963	link	/test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11304) |
+----------------+----------+---------------------+
| minikube start | 51.5s    | 48.9s               |
| enable ingress | 44.5s    | 40.5s               |
+----------------+----------+---------------------+

Times for minikube start: 57.0s 48.7s 50.7s 53.0s 48.0s
Times for minikube (PR 11304) start: 47.8s 50.2s 49.7s 47.6s 49.0s

Times for minikube ingress: 73.3s 39.9s 36.7s 33.8s 38.8s
Times for minikube (PR 11304) ingress: 35.7s 44.2s 49.4s 34.3s 38.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11304) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.7s               |
| enable ingress | 69.0s    | 62.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 22.3s 21.3s 21.8s 21.7s
Times for minikube (PR 11304) start: 21.2s 22.0s 21.9s 21.7s 21.7s

Times for minikube ingress: 28.0s 29.5s 80.0s 29.5s 178.0s
Times for minikube (PR 11304) ingress: 27.5s 109.5s 31.5s 87.0s 59.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11304) |
+----------------+----------+---------------------+
| minikube start | 42.4s    | 44.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.1s 46.9s 43.5s 43.0s 47.4s
Times for minikube (PR 11304) start: 47.1s 43.2s 47.0s 43.2s 43.4s