Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update --disable-driver-mounts default to false #5012

Closed
deepdad opened this issue Aug 7, 2019 · 12 comments
Closed

Update --disable-driver-mounts default to false #5012

deepdad opened this issue Aug 7, 2019 · 12 comments
Labels
co/virtualbox kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@deepdad
Copy link

deepdad commented Aug 7, 2019

Please remove the standard Shared Folder on VirtualBox and guide users how and when to use it. The shared folder isn't used by the Hello minikube tutorial. It can easily be forgotten while users start deploying apps that generate outgoing traffic. I don't know how hard it is to then start uploading data from the default shared folder, but I think it could involve merely a docker image with elevated user rights.

DisableDriverMounts bool // Only used by virtualbox

@deepdad
Copy link
Author

deepdad commented Aug 7, 2019

I would also use a no outgoing egress on all namespaces to be turned off as part of hello minikube: you seem to need outgoing traffic for basic execution. I see a lot of traffic run off from images that are parts of tutorials. I don't know what that is about, probably usage monitoring but that's still univited and never mentioned.

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 7, 2019

It used to be controlled by a flag: minikube start --disable-driver-mounts (#1645 / #1646)

However, for some reason this flag is now missing from v1.3.0 options ?

@medyagh : looks like it was lost from virtualbox, when "grouping": 089bacc

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 7, 2019

Suggest bringing the flag back for v1.3.1, consider flipping it for a future release perhaps ?

Here is the list of folders that are shared by default, when using VirtualBox (and some others):

https://kubernetes.io/docs/setup/learning-environment/minikube/#mounted-host-folders

@afbjorklund afbjorklund added this to the v1.3.1 milestone Aug 7, 2019
@afbjorklund
Copy link
Collaborator

Actually it got lost in the merge conflict resolution: 1b83a89 by @tstromberg

Sadly git doesn't show these (merge commits) properly, when doing the pick-axe.

@tstromberg tstromberg self-assigned this Aug 8, 2019
@deepdad
Copy link
Author

deepdad commented Aug 8, 2019

What pods and stuff have sudo privilege ? After installing minikube with sudo, is running $minikube actually doing $sudo minikube?

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 8, 2019

After installing minikube with sudo, is running $minikube actually doing $sudo minikube

It might (for the none driver), but normally it will do that in the VM - and not on the host.

However, it will not be for re-running minikube itself but for commands like sudo kubeadm

We warn against running minikube as root (or with sudo), there should be no need for that.

You still need enough administrator privileges to use the hypervisor, but that is another story...

@tstromberg
Copy link
Contributor

Related: #5019

@tstromberg tstromberg added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 8, 2019
@tstromberg tstromberg removed their assignment Aug 8, 2019
@tstromberg tstromberg changed the title Please remove the standard Shared Folder on VirtualBox and guide users how and when to use it. Update --disable-driver-mounts default to false Aug 8, 2019
@tstromberg tstromberg removed this from the v1.3.1 milestone Aug 9, 2019
@tstromberg tstromberg added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 18, 2019
@medyagh
Copy link
Member

medyagh commented Dec 16, 2019

we will not do this issue, till we have a solution for non-9p mounts

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 14, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/virtualbox kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

6 participants