Bump cilium to 1.17 for kOps 1.33 #17266
Conversation
Release notes: cilium/cilium#37434
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if version.Minor != 16 { | ||
| allErrs = append(allErrs, field.Invalid(versionFld, v.Version, "Only version 1.16 is supported")) | ||
| if version.Minor != 17 { | ||
| allErrs = append(allErrs, field.Invalid(versionFld, v.Version, "Only version 1.17 is supported")) |
There was a problem hiding this comment.
Do we need to hard-deprecate 1.16 for any reason? I guess this is what we were doing before, but it seems quite aggressive...
There was a problem hiding this comment.
Cilium requires an updated template with every release, so we either have N large templates or we update for all releases.
There was a problem hiding this comment.
See the header of [k8s-1.16-v1.15.yaml.template]:(https://github.com/kubernetes/kops/blob/master/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.16-v1.15.yaml.template)
helm template --release-name cilium cilium/cilium \
--version 1.16.2 \
--namespace kube-system \
--values helm-values.yaml
|
/retest |
|
@ameukam: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
From the cilium e2e failure: |
Release notes: cilium/cilium#37434