-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support python 3.12 for terraform.py in regex expression #11773
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @enrico9034! |
Hi @enrico9034. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are OK as per python 3.12 documentation.
Thanks
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enrico9034, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-failed |
What type of PR is this?
/kind bug
What this PR does / why we need it:
With new changes in pyhton3.12, we need to use a raw string in regex to use backslash-character.
So I changed to use the terraform.py script without issue when you use Python 3.12.
Python 3.12 Language Changes
Which issue(s) this PR fixes:
Fixes #11772
Special notes for your reviewer:
Does this PR introduce a user-facing change?: