-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Configuring EncryptionAlgorithm in Kubeadm v1beta4 #11757
Support Configuring EncryptionAlgorithm in Kubeadm v1beta4 #11757
Conversation
2f2a242
to
af28739
Compare
/ok-to-test |
Signed-off-by: bo.jiang <[email protected]>
af28739
to
02f6985
Compare
/test all |
@ErikJiang: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks @ErikJiang |
/release-note-edit
|
Because #11751 has been reverted. Release note re-add this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
shell: set -o pipefail && openssl x509 -pubkey -in {{ kube_cert_dir }}/ca.crt | openssl rsa -pubin -outform der 2>/dev/null | openssl dgst -sha256 -hex | sed 's/^.* //' | ||
shell: | | ||
set -o pipefail && openssl x509 -pubkey -in {{ kube_cert_dir }}/ca.crt | \ | ||
openssl {% if 'RSA' in kube_asymmetric_encryption_algorithm %}rsa{% elif 'ECDSA' in kube_asymmetric_encryption_algorithm %}ec{% else %}rsa{% endif %} -pubin -outform der 2>/dev/null | \ | ||
openssl dgst -sha256 -hex | sed 's/^.* //' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch. We really need to switch to community.crypto at some point ^.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😊 I tried to optimize this hash calculation logic. #11758
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rnetes-sigs#11757) Signed-off-by: bo.jiang <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
add
ClusterConfiguration.encryptionAlgorithm
to specify an asymmetric encryption algorithm for the cluster's certificates and keys.Which issue(s) this PR fixes:
Fixes #11749
Special notes for your reviewer:
Does this PR introduce a user-facing change?: