preinstall: fix checking that excluded host are cached #11693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lookup was not returning a list, making the difference filter spit out garbage -> query always return a list - hostvars is a dictionnary, so convert to list before selectattr and map back to only get keys
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XS
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
tico88612
approved these changes
Nov 7, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tico88612, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kpoxo6op
pushed a commit
to kpoxo6op/kubespray
that referenced
this pull request
Dec 27, 2024
…gs#11693) - Lookup was not returning a list, making the difference filter spit out garbage -> query always return a list - hostvars is a dictionnary, so convert to list before selectattr and map back to only get keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
See commits
Which issue(s) this PR fixes:
Fixes #11690
Special notes for your reviewer:
Fix the implementation of #11598
@tico88612 can you test this ? My vagrant install is borked at the moment. I tested the assert on a live cluster but only on it's own, not inside kubespray)
Does this PR introduce a user-facing change?: