[cri-o] Switch binaries to libexecdir #11584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
yankay
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Kay Yan <[email protected]>
yankay
force-pushed
the
cri-libexecdir
branch
from
87a72ad to
df70496
Compare
|
HI @VannTen @tico88612 |
tico88612
approved these changes
Sep 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tico88612, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
So far I don't see a problem, since there is an `approve` I don't give `lgtm` (otherwise it would trigger a merge).
Well, yeah, but if it looks good to you, that's not a problem, that's kind of the point ^^.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/kind feature |
k8s-ci-robot
added
the
kind/feature
kpoxo6op
pushed a commit
to kpoxo6op/kubespray
that referenced
this pull request
Dec 27, 2024
Signed-off-by: Kay Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
After the cri-o 1.31, it Switching to /usr/libexec/crio instead of the crio-* binaries, cri-o/packaging#131
So change it follow by the upsteam.
Update youki version to 0.4.1 to fix ci.
Which issue(s) this PR fixes:
Fixes #11565
Special notes for your reviewer:
Does this PR introduce a user-facing change?: